From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] pci: make rte_pci_probe void Date: Wed, 29 Jul 2015 17:34:14 -0700 Message-ID: <20150729173414.742917b4@urahara> References: <1429034136-13482-1-git-send-email-stephen@networkplumber.org> <2862234.7tZV48DKFc@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 66A90C622 for ; Thu, 30 Jul 2015 02:34:05 +0200 (CEST) Received: by pdbbh15 with SMTP id bh15so14215755pdb.1 for ; Wed, 29 Jul 2015 17:34:04 -0700 (PDT) In-Reply-To: <2862234.7tZV48DKFc@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 20 Apr 2015 15:15:36 +0200 Thomas Monjalon wrote: > 2015-04-14 10:55, Stephen Hemminger: > > Since rte_pci_probe always returns 0 or exits via rte_exit() > > there is no point in having it return a value. > > > > Just make it void > > > > Signed-off-by: Stephen Hemminger > > Seems partially superseded by this patch: > http://dpdk.org/dev/patchwork/patch/4347/ > The patch could be redone, but it would break ABI for no good reason. Just drop it.