From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: BUG - KNI broken in 4.2 kernel Date: Fri, 28 Aug 2015 08:48:38 -0700 Message-ID: <20150828084838.7f0654cc@urahara> References: <20150826171516.7160bcb2@urahara> <20150827104543.0138ab53@urahara> <20150828124428.GA11184@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Bruce Richardson Return-path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 94EC75698 for ; Fri, 28 Aug 2015 17:48:28 +0200 (CEST) Received: by pabzx8 with SMTP id zx8so66612864pab.1 for ; Fri, 28 Aug 2015 08:48:27 -0700 (PDT) In-Reply-To: <20150828124428.GA11184@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 28 Aug 2015 13:44:28 +0100 Bruce Richardson wrote: > On Thu, Aug 27, 2015 at 10:45:43AM -0700, Stephen Hemminger wrote: > > On Thu, 27 Aug 2015 15:56:16 +0000 > > "Zhang, Helin" wrote: > >=20 > > > Based on my experience, only one or two users asked for ethtool suppo= rt, then we have it. Before that time, we don=E2=80=99t have KNI ethtool su= pport. > > > I did not mean who uses KNI does not care about it, I mean for those = users who don=E2=80=99t use KNI, they shouldn=E2=80=99t be bothered by the = KNI compilation issues. That=E2=80=99s why I was thinking if we can disable= it by default, but not remove it. > > > =C2=A0 > > > Regards, > > > Helin > >=20 > > Can KNI instead use DPDK hooks to provide generic ethtool semantics. > > That way it would work with all hardware. >=20 > Hi Stephen, >=20 > by this you mean that it's a generic library/kernel driver that acts as a= proxy to make calls > into the ethdev library, rather than driver-specific calls? If so, that's= an idea > that should be well worth pursuing. If it's something else you have in mi= nd, > please clarify. >=20 > Thanks, >=20 > /Bruce Yes, not sure exactly how but the other changes to support ethtool like semantics in DPDK seem to overlap here.