From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] igb_uio: use existing PCI macros
Date: Thu, 10 Sep 2015 20:33:00 +0100
Message-ID: <20150910193300.GA32153@sivlogin002.ir.intel.com>
References: <1441900908-29763-1-git-send-email-ferruh.yigit@intel.com>
 <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2D8A6379E
 for <dev@dpdk.org>; Thu, 10 Sep 2015 21:33:03 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,
> Hello Ferruh,
> 
> On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> 
> > To get pci_dev and vf number from dev, benefit from
> > existing macros in pci.h
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> 
> Correct me if I am wrong but you might need to provide wrappers for kernel
> version <= 2.6.34 (or something that indicates availability of those).

Correct, those macros available after kernel version >= 2.6.34.
If these is any chance that one using older kernel than this version,
instead of having wrappers I am for keeping existing implementation and
drop this patch.

> 
> Please, can you confirm this is just a cleanup and you are not fixing
> anything ?

Just cleanup.

Thanks,
ferruh