From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] rte_sched: remove useless bitmap_free Date: Fri, 11 Sep 2015 12:18:05 -0700 Message-ID: <20150911121805.310fe1ed@urahara> References: <1440780599-14851-1-git-send-email-stephen@networkplumber.org> <1440780599-14851-3-git-send-email-stephen@networkplumber.org> <3EB4FA525960D640B5BDFFD6A3D89126478BAA2E@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Dumitrescu, Cristian" Return-path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 182818D86 for ; Fri, 11 Sep 2015 21:18:04 +0200 (CEST) Received: by pacex6 with SMTP id ex6so82814579pac.0 for ; Fri, 11 Sep 2015 12:18:03 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478BAA2E@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Steve, > > I agree these functions are not doing much at the moment, but I would like to keep them for the reasons below: > > 1. There might be people using them, and we do not want to break their code. Removing them is an ABI change. > > 2. Although they are just placeholders for now, we might need to add more functionality to them going forward, as the implementation evolves. I don't want to change the API now by removing them, and change the API later when we need to add them back. Generally, I think it is good practice to have free functions. The source code base is not a code repository for unused and dead code! If you need to keep things, either get them out of previous history with git or keep them out of tree. Also have a number of patches to remove all #ifdef code that is dead in QoS now.