From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data Date: Mon, 21 Sep 2015 15:40:24 -0700 Message-ID: <20150921154024.3890eb76@urahara> References: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 3B9A98D89 for ; Tue, 22 Sep 2015 00:40:12 +0200 (CEST) Received: by pacex6 with SMTP id ex6so128700192pac.0 for ; Mon, 21 Sep 2015 15:40:11 -0700 (PDT) In-Reply-To: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 16 Sep 2015 22:51:24 +0100 Pablo de Lara wrote: > This is important to avoid trying to start/stop twice a queue, > which will result in undefined behaviour > (which may cause RX/TX disruption). > > Mind that only the PMDs which have queue_start/stop functions > have been changed to update this field, as the functions will > check the queue state before switching it. > > Signed-off-by: Pablo de Lara I agree that the DPDK API should check for buggy manipulation in the control path. But this should be done in generic code. Anything where you have to change any driver is making more work than necessary.