From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v1 1/3] port: add mp/mc ring ports
Date: Tue, 22 Sep 2015 09:34:34 -0700
Message-ID: <20150922093434.4f98e10b@urahara>
References: <1442322395-23365-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <20150921153530.0b198652@urahara>
 <3EB4FA525960D640B5BDFFD6A3D89126478D65D5@IRSMSX108.ger.corp.intel.com>
 <3616846.ZsjBrqIcvx@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
 [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id C281E8DB0
 for <dev@dpdk.org>; Tue, 22 Sep 2015 18:34:24 +0200 (CEST)
Received: by padhy16 with SMTP id hy16so13729421pad.1
 for <dev@dpdk.org>; Tue, 22 Sep 2015 09:34:23 -0700 (PDT)
In-Reply-To: <3616846.ZsjBrqIcvx@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 22 Sep 2015 16:23:51 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-09-22 11:34, Dumitrescu, Cristian:
> > 
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> > > Hemminger
> > > Sent: Tuesday, September 22, 2015 1:36 AM
> > > To: Azarewicz, PiotrX T
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
> > > 
> > > On Tue, 15 Sep 2015 15:06:33 +0200
> > > Piotr Azarewicz <piotrx.t.azarewicz@intel.com> wrote:
> > > 
> > > > +static inline void
> > > > +send_burst_mp(struct rte_port_ring_writer *p)
> > > > +{
> > > 
> > > compiler will inline static functions anyway. No need to add inline qualifier
> > 
> > Hi Stephen,
> > 
> > Using 'static inline' seems to be the standard practice in DPDK and a good practice as well.
> 
> Why do you think it is a good practice?
> Forced inlining can be a random optimization having negative effects.

Agreed. Modern compilers make good decisions.