From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] hash: rename unused field to "reserved" Date: Tue, 22 Sep 2015 16:01:57 -0700 Message-ID: <20150922160157.1f22942c@urahara> References: <1436804751-23156-1-git-send-email-bruce.richardson@intel.com> <1436805525-25916-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id A262456B7 for ; Wed, 23 Sep 2015 01:01:46 +0200 (CEST) Received: by pacbt3 with SMTP id bt3so3526986pac.3 for ; Tue, 22 Sep 2015 16:01:46 -0700 (PDT) In-Reply-To: <1436805525-25916-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 13 Jul 2015 17:38:45 +0100 Bruce Richardson wrote: > The cuckoo hash has a fixed number of entries per bucket, so the > configuration parameter for this is unused. We change this field in the > parameters struct to "reserved" to indicate that there is now no such > parameter value, while at the same time keeping ABI consistency. > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") > > Suggested-by: Thomas Monjalon > Signed-off-by: Bruce Richardson I am sorry this patch went into 2.1 because it broke source code compatibility. To me having source code recompile compatibility is MORE important than ABI compatibility.