From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v1] Move rte_mbuf macros to common header file
Date: Thu, 24 Sep 2015 16:25:37 -0700
Message-ID: <20150924162537.3b20ea3a@urahara>
References: <1443134987-24700-1-git-send-email-rkerur@gmail.com>
 <1443135041-24757-1-git-send-email-rkerur@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ravi Kerur <rkerur@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 87E498E56
 for <dev@dpdk.org>; Fri, 25 Sep 2015 01:25:28 +0200 (CEST)
Received: by pacex6 with SMTP id ex6so86139884pac.0
 for <dev@dpdk.org>; Thu, 24 Sep 2015 16:25:27 -0700 (PDT)
In-Reply-To: <1443135041-24757-1-git-send-email-rkerur@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 24 Sep 2015 15:50:41 -0700
Ravi Kerur <rkerur@gmail.com> wrote:

> Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT
> are defined in each PMD driver file. Move those macros into common
> lib/librte_mbuf/rte_mbuf.h file. All PMD drivers include rte_mbuf.h
> file directly/indirectly hence no additionl header file inclusion
> is necessary.
> 
> Compiled for:
>     > x86_64-native-linuxapp-clang
>     > x86_64-native-linuxapp-gcc
>     > i686-native-linuxapp-gcc
>     > x86_64-native-bsdapp-gcc
>     > x86_64-native-bsdapp-clang  
> 
> Tested on:
>     > x86_64 Ubuntu 14.04, testpmd and 'make test'
>     > FreeBSD 10.1, testpmd  
> 
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>

I like the idea, should have been done long ago.

My only gripe is that you should do this as inline functions
rather than macros. Inline functions are type safe, macros are not.