From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] ixgbe: prefetch cacheline after pointer
	becomes valid
Date: Fri, 25 Sep 2015 16:22:33 +0100
Message-ID: <20150925152232.GA29324@bricha3-MOBL3>
References: <1443140606-18241-1-git-send-email-zoltan.kiss@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Zoltan Kiss <zoltan.kiss@linaro.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id C3BD18E56
 for <dev@dpdk.org>; Fri, 25 Sep 2015 17:22:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1443140606-18241-1-git-send-email-zoltan.kiss@linaro.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Sep 24, 2015 at 05:23:26PM -0700, Zoltan Kiss wrote:
> At the original point the rx_pkts[pos( + n)] pointers are not initialized, so
> the code is prefetching random data.
> 
> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
> 

Apart from the whitespace issues pointed out by John, this fix looks ok and
testing shows no performance impact (as expected).

/Bruce