From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 0/4] ethdev: minor cleanup
Date: Mon, 28 Sep 2015 11:23:31 +0100
Message-ID: <20150928102331.GA29488@bricha3-MOBL3>
References: <1434108496-1993-1-git-send-email-bruce.richardson@intel.com>
 <1441811374-28984-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 55D8A1DB1
 for <dev@dpdk.org>; Mon, 28 Sep 2015 12:23:35 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1441811374-28984-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Sep 09, 2015 at 04:09:30PM +0100, Bruce Richardson wrote:
> This patchset performs two cleanups:
> 1. Four functions in ethdev.c which were enabled for debug only have been
>   merged into their inlined header-file counterparts. This change required that
>   a number of macros be renamed and moved to the header file too. The macro changes
>   are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3.
> 2. Checks for valid function pointers are added to the API calls for reading
>   the descriptor ring count, and checking for a valid descriptor. This is because
>   these functions are not implemented by most drivers, and so it's far safer to
>   have the check.
> 
> ---
> 
> V2 Changes:
> * Rebased to latest DPDK codebase
> * Changed type from uint32_t to int for the count function, on the basis of
> feedback received.
> 
> Bruce Richardson (4):
>   ethdev: rename macros to have RTE_ETH prefix
>   ethdev: move error checking macros to header
>   ethdev: remove duplicated debug functions
>   ethdev: check driver support for functions
> 
>  lib/librte_ether/rte_ethdev.c | 674 ++++++++++++++++++------------------------
>  lib/librte_ether/rte_ethdev.h | 121 ++++++--
>  2 files changed, 375 insertions(+), 420 deletions(-)
> 
> -- 

Thomas, all,

Any comments on this set?

/Bruce