From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] hash: fix incorrect lookup if key is all zero Date: Mon, 28 Sep 2015 11:29:48 +0100 Message-ID: <20150928102948.GA27944@bricha3-MOBL3> References: <1442480658-4741-1-git-send-email-pablo.de.lara.guarch@intel.com> <1442485848-25401-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AF790374F for ; Mon, 28 Sep 2015 12:29:54 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1442485848-25401-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 17, 2015 at 11:30:48AM +0100, Pablo de Lara wrote: > If user has not added an all zero key in the hash table, > and tries to look it up, it results in an incorrect hit, > as dummy slot in the key table has all zero as well. > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") > > Signed-off-by: Pablo de Lara > --- > Changes in v2: > - Include Fixes: tag in commit message > > doc/guides/rel_notes/release_2_2.rst | 5 +++++ > lib/librte_hash/rte_cuckoo_hash.c | 27 +++++++++++++++++---------- > 2 files changed, 22 insertions(+), 10 deletions(-) > Acked-by: Bruce Richardson