From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 3/8] virtio: add software rx ring, fake_buf, simple_rxtx into virtqueue Date: Tue, 29 Sep 2015 09:15:05 -0700 Message-ID: <20150929091505.121c7078@urahara> References: <1443537953-23917-1-git-send-email-huawei.xie@intel.com> <1443537953-23917-4-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Huawei Xie Return-path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id C4A105A44 for ; Tue, 29 Sep 2015 18:14:56 +0200 (CEST) Received: by padhy16 with SMTP id hy16so10242705pad.1 for ; Tue, 29 Sep 2015 09:14:56 -0700 (PDT) In-Reply-To: <1443537953-23917-4-git-send-email-huawei.xie@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 29 Sep 2015 22:45:48 +0800 Huawei Xie wrote: > + if (vq->sw_ring) > + rte_free(vq->sw_ring); rte_free of NULL is a nop so conditional here is unnecessary