From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] ethdev: remove the imissed deprecation tag Date: Tue, 13 Oct 2015 08:53:15 -0700 Message-ID: <20151013085315.7d27e903@xeon-e3> References: <1443601256-181129-1-git-send-email-maryam.tahhan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Maryam Tahhan Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 862DD5A63 for ; Tue, 13 Oct 2015 17:53:07 +0200 (CEST) Received: by pabve7 with SMTP id ve7so25295629pab.2 for ; Tue, 13 Oct 2015 08:53:06 -0700 (PDT) In-Reply-To: <1443601256-181129-1-git-send-email-maryam.tahhan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 30 Sep 2015 09:20:56 +0100 Maryam Tahhan wrote: > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index fa06554..78bd94d 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -194,8 +194,7 @@ struct rte_eth_stats { > uint64_t opackets; /**< Total number of successfully transmitted packets.*/ > uint64_t ibytes; /**< Total number of successfully received bytes. */ > uint64_t obytes; /**< Total number of successfully transmitted bytes. */ > - uint64_t imissed; > - /**< Deprecated; Total of RX missed packets (e.g full FIFO). */ If you want to deprecate a structure field, it works better to mark it with __attribute__((deprecated)) that way all use of that field in code will be flagged. Comments are advisory only and often never spotted.