From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Unsafe array accesses in rte_sched.c
Date: Fri, 16 Oct 2015 09:10:02 -0700
Message-ID: <20151016091002.2ef7d507@xeon-e3>
References: <5620BA12.9060702@netinsight.net>
 <3EB4FA525960D640B5BDFFD6A3D89126478F0C50@IRSMSX108.ger.corp.intel.com>
 <562100BF.9010107@netinsight.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Simon =?UTF-8?B?S8OlZ3N0csO2bQ==?= <simon.kagstrom@netinsight.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id C28E88D9B
 for <dev@dpdk.org>; Fri, 16 Oct 2015 18:09:53 +0200 (CEST)
Received: by pabrc13 with SMTP id rc13so124566195pab.0
 for <dev@dpdk.org>; Fri, 16 Oct 2015 09:09:53 -0700 (PDT)
In-Reply-To: <562100BF.9010107@netinsight.net>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 16 Oct 2015 15:50:55 +0200
Simon K=C3=A5gstr=C3=B6m <simon.kagstrom@netinsight.net> wrote:

> On 2015-10-16 15:39, Dumitrescu, Cristian wrote:
> >>         port->qsize_add[12] =3D port->qsize_add[11] + port->qsize[2];
> >>         port->qsize_add[13] =3D port->qsize_add[12] + port->qsize[3];
> >>         port->qsize_add[14] =3D port->qsize_add[13] + port->qsize[3];
> >>         port->qsize_add[15] =3D port->qsize_add[14] + port->qsize[3];
> >>
> >>         port->qsize_sum =3D port->qsize_add[15] + port->qsize[3];
> >>   }
> >>
> >> but port->qsize is actually defined as
> >>
> >>   uint16_t qsize[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> >>
> >=20
> > Not sure what you see "unsafe" here: qsize is an array of 4 elements, w=
hile qsize_add is a different array of 16 elements? Please explain.
>=20
> Sorry, I should have been more explicit: What I mean that the code
> should loop over RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE instead of
> hard-coding the numbers.
>=20
> It certainly works with the current RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE,
> but it would be safer (and in my opinion more clear) if it would not
> assume RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE =3D=3D 4.
>=20
> // Simon

Unfortunately, current code has lots of hard wired assumptions about number
of traffic classes. Lots of manually loop unrolling etc. It would be better
if this was done using loops and telling compiler to unroll critical loops.