From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: RSS API discussion Date: Fri, 16 Oct 2015 17:28:10 +0200 Message-ID: <20151016152810.GD2594@autoinstall.dev.6wind.com> References: <6A0DE07E22DDAD4C9103DF62FEBC09090209FB49@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Lu, Wenzhuo" Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 009CBCF9 for ; Fri, 16 Oct 2015 17:28:28 +0200 (CEST) Received: by wijq8 with SMTP id q8so16390443wij.0 for ; Fri, 16 Oct 2015 08:28:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090209FB49@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2015 at 01:40:00PM +0000, Lu, Wenzhuo wrote: > Hi N=E9lio, > =20 > > Hi Wenzhuo, > >=20 > > We should discuss about this API for a future release of DPDK because= this one > > lacks in flexibility. Some other NICs have indirection tables with a > > different/configurable size, and the current API does not help to man= age it. > >=20 > > For ConnectX-4 I have made a lot of hacks to avoid changing the DPDK = API, > > "[dpdk-dev] [PATCH 0/3] Add RETA configuration to MLX5". > > http://dpdk.org/ml/archives/dev/2015-October/024681.html > >=20 > > From a user point of view, to update the RETA table, the API expects = the user to > > know the size of it to update or query. With your patchset, Intel ha= ve two > > indirection table sizes now, with Mellanox ConnectX-4, I fixed to the= size of 512 > > entries because it is not fixed by default. > >=20 > > How about discussing this in a separate thread? > Sure, I changed the tittle. > But I'm afraid I don't catch up with you. I have 2 questions, 1, Why th= e reta size cannot be predict on Mellanox ConnectX-4? 2, I don't underst= and the meaning when you say the reta size is not fixed by default on Mel= lanox ConnectX-4. > Would you like to give more details of the Mellanox ConnectX-4's behavi= or? It'll be helpful to understand this problem. On Connexct-4 we can configure the indirection table size with any power of two up to 512 entries. The current API only expects RETA tables size to be a multiple of RTE_RETA_GROUP_SIZE i.e. 64. To handle any kind of NICs, a simple array of N (RETA table size) elements with the data, instead of something in multiple of 64 would be easier to use, something like: struct rte_eth_rss_reta_entry { uint16_t idx; /* index to query/update. */ uint16_t reta; /* redirection value. */ }; We should update the API to take an array of such entries plus its size. It would also make update and query easier. --=20 N=E9lio Laranjeiro 6WIND