From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] kni: allow per-net instances
Date: Wed, 21 Oct 2015 09:22:02 -0700
Message-ID: <20151021092202.0fd6932a@xeon-e3>
References: <1435831933-13339-1-git-send-email-dex.chen@ruckuswireless.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Dex Chen <dex.chen@ruckuswireless.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id EF272C3D0
 for <dev@dpdk.org>; Wed, 21 Oct 2015 18:21:52 +0200 (CEST)
Received: by padhk11 with SMTP id hk11so59019442pad.1
 for <dev@dpdk.org>; Wed, 21 Oct 2015 09:21:52 -0700 (PDT)
In-Reply-To: <1435831933-13339-1-git-send-email-dex.chen@ruckuswireless.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  2 Jul 2015 18:12:13 +0800
Dex Chen <dex.chen@ruckuswireless.com> wrote:

> +static __net_exit void kni_exit_net(struct net *net)
> +{
> +	/*
> +	 * Nothing to do here.
> +	 * Assuming all cleanup jobs were done in kni_release().
> +	 */
> +}

I don't think you need an exit stub. Looks like kernel does
the right thing if it is just NULL.

Since this is kernel code, it should pass the kernel checkpatch.

$ checkpatch.pl /tmp/kni-netns.patch WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#84: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:99:
+	volatile unsigned long device_in_use; /* device in use flag */

WARNING: line over 80 characters
#166: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:196:
+	/* kni device can be opened by one user only per netns, test and set bit */

WARNING: line over 80 characters
#256: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:353:
+kni_ioctl_create(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param)

WARNING: line over 80 characters
#319: FILE: lib/librte_eal/linuxapp/kni/kni_misc.c:544:
+kni_ioctl_release(struct net *net, unsigned int ioctl_num, unsigned long ioctl_param)

total: 0 errors, 4 warnings, 285 lines checked

/tmp/kni-netns.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.