From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] lib: rte_*_create gives NULL/EEXIST on duped name Date: Wed, 21 Oct 2015 11:59:03 +0100 Message-ID: <20151021105903.GC16140@bricha3-MOBL3> References: <1445372497-817-1-git-send-email-yrobot@amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Yoni Fogel Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 12B68940A for ; Wed, 21 Oct 2015 12:59:16 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1445372497-817-1-git-send-email-yrobot@amazon.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 20, 2015 at 01:21:37PM -0700, Yoni Fogel wrote: > Also fixed a bug in many of them where if the rte_malloc of > the TAILQ fails, then we return a pointer to some arbitrary > existing struct. > > Signed-off-by: Yoni Fogel Thanks, looks like good fixes. However, I think for fixes like these they are better as one-fix-per-patch, because in this case we have the title referring to one fix, while the comment log describes a completely separate fix. Can you perhaps do a V2 as a two-patch set? /Bruce > --- > lib/librte_acl/rte_acl.c | 53 +++++++++++++++++++++------------------ > lib/librte_hash/rte_cuckoo_hash.c | 6 +++-- > lib/librte_hash/rte_fbk_hash.c | 5 +++- > lib/librte_lpm/rte_lpm.c | 5 +++- > lib/librte_lpm/rte_lpm6.c | 5 +++- > 5 files changed, 44 insertions(+), 30 deletions(-) >