From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v4] nfp: new poll mode driver for netronome nfp-6xxx card Date: Fri, 23 Oct 2015 09:05:48 -0700 Message-ID: <20151023090548.5fa59e0e@xeon-e3> References: <1445596563-16818-1-git-send-email-alejandro.lucero@netronome.com> <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: "Alejandro.Lucero" Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 8BCDF5963 for ; Fri, 23 Oct 2015 18:05:38 +0200 (CEST) Received: by pabrc13 with SMTP id rc13so121674172pab.0 for ; Fri, 23 Oct 2015 09:05:37 -0700 (PDT) In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 23 Oct 2015 11:36:02 +0100 "Alejandro.Lucero" wrote: > +static inline __u32 > +nfp_qcp_read(__u8 *q, enum nfp_qcp_ptr ptr) > +{ > + __u32 off; > + __u32 val; > + Please don't use Linux kernel typedefs (__u32) in DPDK code. Instead use stdint types (uint32_t)