From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper Date: Fri, 23 Oct 2015 09:56:11 -0700 Message-ID: <20151023095611.46a5d69f@xeon-e3> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1445615606-3885-2-git-send-email-thomas.monjalon@6wind.com> <20151023090325.3a83fa0c@xeon-e3> <4288301.N0F7Gaqfh8@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 513E85A17 for ; Fri, 23 Oct 2015 18:56:02 +0200 (CEST) Received: by pasz6 with SMTP id z6so122874372pas.2 for ; Fri, 23 Oct 2015 09:56:01 -0700 (PDT) In-Reply-To: <4288301.N0F7Gaqfh8@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 23 Oct 2015 18:34:23 +0200 Thomas Monjalon wrote: > > Please keep some of these: > > PARENTHESIS_ALIGNMENT > > It is not written in the DPDK coding rules that > "Alignment should match open parenthesis" I think code looks nicer if this rule is followed. Ditto for the LINE_SPACING rule.