From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 00/11] Port XStats Date: Thu, 29 Oct 2015 06:32:16 +0900 Message-ID: <20151029063216.4675da65@samsung9> References: <1443606022-13581-2-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: Tom Crugnale Return-path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 73EF38D9D for ; Wed, 28 Oct 2015 22:32:24 +0100 (CET) Received: by padhy1 with SMTP id hy1so12033617pad.0 for ; Wed, 28 Oct 2015 14:32:23 -0700 (PDT) In-Reply-To: <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 28 Oct 2015 17:35:09 +0000 Tom Crugnale wrote: > Hi Harry, > > We are planning on using the xstats API for periodic stats collection through a polling thread. This would be done in a generic NIC agnostic manner, which would require that the xstats identifiers have consistent naming amongst all of the NIC types. It would likely be polled several times per second and would only gather a subset of all available xstats types. > > I have reviewed your patches and am interested in providing some API enhancements and bugfixes. Are you willing to provide feedback on such changes? > > Thank you, > Tom The whole point of xstats is to allow device specific statistics. Consistent use of names is good from a user interface point of view, but probably not a hard requirement.