From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 2/2] lib/lpm:fix an initialization issue of valid_group in the delete_depth_small() Date: Fri, 30 Oct 2015 14:22:27 +0000 Message-ID: <20151030142227.GB10520@bricha3-MOBL3> References: <1446210879-14242-1-git-send-email-jijiang.liu@intel.com> <1446210879-14242-3-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Jijiang Liu Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D56158DA1 for ; Fri, 30 Oct 2015 15:22:55 +0100 (CET) Content-Disposition: inline In-Reply-To: <1446210879-14242-3-git-send-email-jijiang.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2015 at 09:14:39PM +0800, Jijiang Liu wrote: Title can be shortened to: "lpm: fix initialization of valid_group field" > Fixes an initialization issue of 'valid_group' in the delete_depth_small function. > > In this function, use new rte_lpm_tbl8_entry we call A to replace the old rte_lpm_tbl8_entry. But the valid_group do not set VALID, so it > will be INVALID. > > Then when adding a new route which depth is > 24,the tbl8_alloc() function will search the rte_lpm_tbl8_entrys to find INVALID > valid_group, and it will return the A to the add_depth_big function, so A's data is overridden. > Not sure this message is entirely clear. How about: When adding an entry to a tbl8, the .valid_group field should always be set, so that future adds do not accidently find and use this table, thinking it is currently invalid, i.e. unused, and thereby overwrite existing entries. > Signed-off-by: NaNa > > --- > lib/librte_lpm/rte_lpm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c > index 57ec2f0..3981452 100644 > --- a/lib/librte_lpm/rte_lpm.c > +++ b/lib/librte_lpm/rte_lpm.c > @@ -769,6 +769,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked, > > struct rte_lpm_tbl8_entry new_tbl8_entry = { > .valid = VALID, > + .valid_group = VALID, > .depth = sub_rule_depth, > .next_hop = lpm->rules_tbl > [sub_rule_index].next_hop, > -- > 1.7.7.6 >