From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 09/13] mlx5: add link update device operation Date: Mon, 2 Nov 2015 09:52:17 -0800 Message-ID: <20151102095217.7d40e38f@xeon-e3> References: <1444067589-29513-1-git-send-email-adrien.mazarguil@6wind.com> <1446231162-8075-1-git-send-email-adrien.mazarguil@6wind.com> <1446231162-8075-10-git-send-email-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Adrien Mazarguil Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 6AE578D96 for ; Mon, 2 Nov 2015 18:52:07 +0100 (CET) Received: by pabfh17 with SMTP id fh17so30823793pab.0 for ; Mon, 02 Nov 2015 09:52:06 -0800 (PST) In-Reply-To: <1446231162-8075-10-git-send-email-adrien.mazarguil@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 30 Oct 2015 19:52:38 +0100 Adrien Mazarguil wrote: > +static int > +mlx5_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete) > +{ > + struct priv *priv = dev->data->dev_private; > + struct ethtool_cmd edata = { > + .cmd = ETHTOOL_GSET > + }; > + struct ifreq ifr; > + struct rte_eth_link dev_link; > + int link_speed = 0; > + > + (void)wait_to_complete; DPDK style is to use the __rte_unused attribute rather than dummy statements to avoid unused warnings.