From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] mk: fix ABI versioning compile error
	for	combined shared library
Date: Tue, 3 Nov 2015 09:20:33 +0000
Message-ID: <20151103092033.GA16414@sivlogin002.ir.intel.com>
References: <20151102102023.GA29052@sivlogin002.ir.intel.com>
 <1446477827-11541-1-git-send-email-ferruh.yigit@intel.com>
 <56385CDD.2030909@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Eric Kinzie <ekinzie@brocade.com>
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3C9968E6E
 for <dev@dpdk.org>; Tue,  3 Nov 2015 10:20:37 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <56385CDD.2030909@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Nov 03, 2015 at 09:06:05AM +0200, Panu Matilainen wrote:
> On 11/02/2015 05:23 PM, Ferruh Yigit wrote:
>> Fixes following error:
>>    LD libdpdk.so
>>    /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found
>>    for symbol <function>@DPDK_x.y
>>
>> Defines version symbols in a fixed path libdpdk.map file and this
>> value hardcoded into makefile
>
> Hold on. What problem is this supposed to be fixing?
This patch is to fix combined library compilation error when ABI versining used.
Currently if ABI version macros used (VERSION_SYMBOL), we are not able to compile combined shared library.

> If its for the bonding thing (as it'd appear from the threading), NAK. 
Nothing directly related to the bonding, just issue observed in this thread.

> The symbol versioning in 
> that patch is confused needs to be fixed there instead of inventing strange 
> workarounds elsewhere.
>
This is not intented to be a workaround but a fix, unless you have a better idea.

ferruh