From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH] cmdline: increase commandline buffer size to
 512
Date: Thu, 5 Nov 2015 17:50:44 +0100
Message-ID: <20151105165044.GA18667@autoinstall.dev.6wind.com>
References: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: John McNamara <john.mcnamara@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 3F9D08E6C
 for <dev@dpdk.org>; Thu,  5 Nov 2015 17:51:27 +0100 (CET)
Received: by wmll128 with SMTP id l128so16649399wml.0
 for <dev@dpdk.org>; Thu, 05 Nov 2015 08:51:27 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote:
> Increase commandline buffer size to 512 to allow for longer
> commandlines required by testpmd when dealing with flow
> director and IPv6 addresses.
>=20
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> ---
>  lib/librte_cmdline/cmdline_rdline.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/c=
mdline_rdline.h
> index b9aad9b..72e2dad 100644
> --- a/lib/librte_cmdline/cmdline_rdline.h
> +++ b/lib/librte_cmdline/cmdline_rdline.h
> @@ -93,7 +93,7 @@ extern "C" {
>  #endif
> =20
>  /* configuration */
> -#define RDLINE_BUF_SIZE 256
> +#define RDLINE_BUF_SIZE 512
>  #define RDLINE_PROMPT_SIZE  32
>  #define RDLINE_VT100_BUF_SIZE  8
>  #define RDLINE_HISTORY_BUF_SIZE BUFSIZ
> --=20
> 1.8.1.4
>=20

I have faced the same issue.  For some commands this value is still too=20
low.  For example,  RETA update can not be used, the command line limits=20
he configuration to 34 entries.

See http://dpdk.org/ml/archives/dev/2015-October/024681.html
and particularly=20
http://dpdk.org/ml/archives/dev/2015-October/024682.html

It was too late to announce an ABI change so we left out the cmdline=20
size update.

Olivier, Thomas, what do you think about this?  It seems this is really=20
blocking.

--=20
N=E9lio Laranjeiro
6WIND