From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 2/4] ethdev: move error checking macros to
 header
Date: Fri, 6 Nov 2015 11:49:05 +0000
Message-ID: <20151106114904.GA13920@bricha3-MOBL3>
References: <1441811374-28984-1-git-send-email-bruce.richardson@intel.com>
 <1446552059-5446-1-git-send-email-bruce.richardson@intel.com>
 <1446552059-5446-3-git-send-email-bruce.richardson@intel.com>
 <4698587.GS9blBozDC@xps13> <20151104102418.GN3518@6wind.com>
 <20151104103957.4cabd090@xeon-e3> <20151105150918.GV3518@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: Stephen Hemminger <stephen@networkplumber.org>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 14980591F
 for <dev@dpdk.org>; Fri,  6 Nov 2015 12:49:17 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20151105150918.GV3518@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> Bruce is asking for a consensus about -pedantic, whether we want to do =
the
> extra effort to support it in DPDK. Since I like checking for -pedantic
> errors, it's enabled for mlx4 and mlx5 when compiling these drivers in
> debugging mode. There is currently no established rule in DPDK against =
this.
>=20
> I'm arguing that most C headers (C compiler, libc, most libraries, even=
 the
> Linux kernel in uapi to an extent) provide standards compliant includes
> because they cannot predict or force particular compilation flags on
> user applications.
>=20
> If we consider DPDK as a system wide library, I think we should do it a=
s
> well in all installed header files. If we choose not to, then we must
> document that our code is not standard, -pedantic is unsupported and I'=
ll
> have to drop it from mlx4 and mlx5.
>=20
> --=20
> Adrien Mazarguil
> 6WIND

Hi Adrien,

I'm trying to dig into this a bit more now, and try out using a static in=
line
function, but I'm having trouble getting DPDK to compile with the mlx dri=
vers
turned on in the config. I'm trying to follow the instructions here:
http://dpdk.org/doc/guides/nics/mlx4.html, but it's not clearly called ou=
t what
requirements are for compilation vs requirements for running the PMD.

I'm running Fedora 23, and installed the libibverbs-devel package, but wh=
en I
compile I get the following error:

=3D=3D Build drivers/net/mlx4
  CC mlx4.o
  /home/bruce/ethdev-cleanup/drivers/net/mlx4/mlx4.c: In function =E2=80=98=
txq_cleanup=E2=80=99:
  /home/bruce/ethdev-cleanup/drivers/net/mlx4/mlx4.c:886:37: error: stora=
ge size of =E2=80=98params=E2=80=99 isn=E2=80=99t known
    struct ibv_exp_release_intf_params params;
                                       ^
compilation terminated due to -Wfatal-errors.

Any suggestions on the fix for this?

Thanks,
/Bruce