From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3 2/4] ethdev: move error checking macros to header Date: Fri, 6 Nov 2015 13:25:39 +0100 Message-ID: <20151106122539.GC4013@6wind.com> References: <20151106115244.GB13920@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 794375A58 for ; Fri, 6 Nov 2015 13:25:58 +0100 (CET) Received: by wikq8 with SMTP id q8so29240966wik.1 for ; Fri, 06 Nov 2015 04:25:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151106115244.GB13920@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, On Fri, Nov 06, 2015 at 11:52:44AM +0000, Bruce Richardson wrote: > +Adrien on To: line >=20 > Email user/client fail on original. :-( >=20 > ----- Forwarded message from Bruce Richardson ----- >=20 > Date: Fri, 6 Nov 2015 11:49:05 +0000 > From: Bruce Richardson > To: Stephen Hemminger , Thomas Monjalon , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macr= os to header > User-Agent: Mutt/1.5.23 (2014-03-12) >=20 > On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote: > > Bruce is asking for a consensus about -pedantic, whether we want to d= o the > > extra effort to support it in DPDK. Since I like checking for -pedant= ic > > errors, it's enabled for mlx4 and mlx5 when compiling these drivers i= n > > debugging mode. There is currently no established rule in DPDK agains= t this. > >=20 > > I'm arguing that most C headers (C compiler, libc, most libraries, ev= en the > > Linux kernel in uapi to an extent) provide standards compliant includ= es > > because they cannot predict or force particular compilation flags on > > user applications. > >=20 > > If we consider DPDK as a system wide library, I think we should do it= as > > well in all installed header files. If we choose not to, then we must > > document that our code is not standard, -pedantic is unsupported and = I'll > > have to drop it from mlx4 and mlx5. > >=20 > > --=20 > > Adrien Mazarguil > > 6WIND >=20 > Hi Adrien, >=20 > I'm trying to dig into this a bit more now, and try out using a static = inline > function, but I'm having trouble getting DPDK to compile with the mlx d= rivers > turned on in the config. I'm trying to follow the instructions here: > http://dpdk.org/doc/guides/nics/mlx4.html, but it's not clearly called = out what > requirements are for compilation vs requirements for running the PMD. >=20 > I'm running Fedora 23, and installed the libibverbs-devel package, but = when I > compile I get the following error: >=20 > =3D=3D Build drivers/net/mlx4 > CC mlx4.o > /home/bruce/ethdev-cleanup/drivers/net/mlx4/mlx4.c: In function =E2=80= =98txq_cleanup=E2=80=99: > /home/bruce/ethdev-cleanup/drivers/net/mlx4/mlx4.c:886:37: error: sto= rage size of =E2=80=98params=E2=80=99 isn=E2=80=99t known > struct ibv_exp_release_intf_params params; > ^ > compilation terminated due to -Wfatal-errors. >=20 > Any suggestions on the fix for this? This is a known issue, libibverbs-devel package from Fedora 23 most likel= y does not support extended types and functions required by mlx4. You shoul= d remove the packages that come with your distribution and install librarie= s versions from Mellanox OFED as described in the next section: http://dpdk.org/doc/guides/nics/mlx4.html#getting-mellanox-ofed Note: no need to fully install OFED for compilation checks, you can extra= ct an updated libibverbs package from the archive. --=20 Adrien Mazarguil 6WIND