From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 8/8] examples/vhost:support TX offload in
 vhost sample
Date: Mon, 9 Nov 2015 16:51:40 +0800
Message-ID: <20151109085140.GO2326@yliu-dev.sh.intel.com>
References: <1446634456-413-1-git-send-email-jijiang.liu@intel.com>
 <1446634456-413-9-git-send-email-jijiang.liu@intel.com>
 <20151109041707.GJ2326@yliu-dev.sh.intel.com>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC22BD954D@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id B0D935424
 for <dev@dpdk.org>; Mon,  9 Nov 2015 09:48:40 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BD954D@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Nov 09, 2015 at 08:17:24AM +0000, Liu, Jijiang wrote:
> 
> 
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Monday, November 09, 2015 12:17 PM
> > To: Liu, Jijiang
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 8/8] examples/vhost:support TX offload in
> > vhost sample
> > 
> > On Wed, Nov 04, 2015 at 06:54:16PM +0800, Jijiang Liu wrote:
> > > Change the vhost sample to support and test TX offload.
> > >
> > > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> > > ---
> > >  examples/vhost/main.c |  128
> > > ++++++++++++++++++++++++++++++++++++++++++-------
> > >  1 files changed, 111 insertions(+), 17 deletions(-)
> > >
> > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index
> > > 9eac2d0..06e1e8b 100644
> > > --- a/examples/vhost/main.c
> > > +++ b/examples/vhost/main.c
> > > @@ -50,6 +50,10 @@
> > >  #include <rte_string_fns.h>
> > >  #include <rte_malloc.h>
> > >  #include <rte_virtio_net.h>
> > > +#include <rte_tcp.h>
> > > +#include <rte_ip.h>
> > > +#include <rte_udp.h>
> > > +#include <rte_sctp.h>
> > >
> > >  #include "main.h"
> > >
> > > @@ -140,6 +144,8 @@
> > >
> > Actually, I'd like to see TSO/CSUM offloading is enabled by default:
> > they are so common, and they are enabled in a lot places by default, say,
> > kernel, qemu. There is no reason to make it "disable" here.
> > 
> This is configuration  only in the vhost sample,  but TSO/CSUM is enabled by default in lib leyer.
> 
> If user want to use it in vhost sample, just change the configuration.

So, why do you want to disable it by default then?

	--yliu