From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH] cmdline: increase commandline buffer size to 512 Date: Mon, 9 Nov 2015 16:54:25 +0100 Message-ID: <20151109155425.GK1968@autoinstall.dev.6wind.com> References: <1446717516-17692-1-git-send-email-john.mcnamara@intel.com> <20151105165044.GA18667@autoinstall.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Mcnamara, John" Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CB8A5559C for ; Mon, 9 Nov 2015 16:54:44 +0100 (CET) Received: by wmec201 with SMTP id c201so87036977wme.0 for ; Mon, 09 Nov 2015 07:54:44 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 09, 2015 at 11:45:04AM +0000, Mcnamara, John wrote: >=20 >=20 > > -----Original Message----- > > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Thursday, November 5, 2015 4:51 PM > > To: Mcnamara, John; Olivier Matz; Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] cmdline: increase commandline buffer = size > > to 512 > >=20 > > On Thu, Nov 05, 2015 at 09:58:36AM +0000, John McNamara wrote: > > > Increase commandline buffer size to 512 to allow for longer > > > commandlines required by testpmd when dealing with flow director an= d > > > IPv6 addresses. > > > > > > ... > > > > > > /* configuration */ > > > -#define RDLINE_BUF_SIZE 256 > > > +#define RDLINE_BUF_SIZE 512 > > > > >=20 > > I have faced the same issue. For some commands this value is still t= oo > > low. For example, RETA update can not be used, the command line lim= its > > he configuration to 34 entries. > >=20 > > See http://dpdk.org/ml/archives/dev/2015-October/024681.html > > and particularly > > http://dpdk.org/ml/archives/dev/2015-October/024682.html > >=20 > > It was too late to announce an ABI change so we left out the cmdline > > size update. > >=20 > > Olivier, Thomas, what do you think about this? It seems this is real= ly > > blocking. >=20 > Hi, >=20 > Since the change breaks ABI I'll self nack. >=20 > However, this is something that should be fixed since it will affect an= y DPDK application with a long commandline. >=20 > I can put a warning of future ABI breakage in the release notes but I s= ee that there are other #defines that you need to increase in your patchs= et so do you want to submit the ABI deprecation notice? >=20 > John. > --=20 Hi John, I will do it, I have another depreciation related to RETA. Thanks. --=20 N=E9lio Laranjeiro 6WIND