From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v4 3/8] virtio/lib:add vhost TX checksum support capabilities Date: Wed, 11 Nov 2015 16:26:57 +0800 Message-ID: <20151111082657.GZ2326@yliu-dev.sh.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-4-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Jijiang Liu Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EA4BB8D96 for ; Wed, 11 Nov 2015 09:23:07 +0100 (CET) Content-Disposition: inline In-Reply-To: <1447224046-1169-4-git-send-email-jijiang.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote: > Add vhost TX offload(CSUM and TSO) support capabilities. Claiming first that we support something, and then actually implementing in a later patch is wrong, as at this stage, we actually does not support that, hence, the functionality is broken. --yliu > > Signed-off-by: Jijiang Liu > --- > lib/librte_vhost/virtio-net.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index 14278de..81bd309 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -77,7 +77,11 @@ static struct virtio_net_config_ll *ll_root; > (VHOST_SUPPORTS_MQ) | \ > (1ULL << VIRTIO_F_VERSION_1) | \ > (1ULL << VHOST_F_LOG_ALL) | \ > - (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) > + (1ULL << VHOST_USER_F_PROTOCOL_FEATURES) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > + (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > + (1ULL << VIRTIO_NET_F_CSUM)) > + > static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; > > > -- > 1.7.7.6