From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] hash: add rte_hash_set_cmp_func() function.
Date: Fri, 13 Nov 2015 10:00:25 +0000
Message-ID: <20151113100024.GA3684@bricha3-MOBL3>
References: <1447396093-29004-1-git-send-email-kamasamikon@qq.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
To: kamasamikon <kamasamikon@qq.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D2B4C93B2
 for <dev@dpdk.org>; Fri, 13 Nov 2015 11:00:53 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1447396093-29004-1-git-send-email-kamasamikon@qq.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 13, 2015 at 02:28:13PM +0800, kamasamikon wrote:
> Give user a chance to costomize the hash key compare function.
> The default rte_hash_cmp_eq function is set in the rte_hash_create
> function, but these builtin ones may not good enough, so the user
> may call this to override the default one.
> 
> Signed-off-by: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
> ---
Hi,

Just a few small comments:

When adding a new function, you'll need to update the map file for the library
with the new API so it can be correctly versionned.

Also, using function pointers does not work with DPDK multi-process, so, at 
minimum, you need to add to the doxygen documentation that your new function cannot
be used in multi-process mode.

/Bruce