From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf Date: Fri, 20 Nov 2015 08:35:27 -0800 Message-ID: <20151120083527.64ffd576@xeon-e3> References: <1448000935-29391-1-git-send-email-shaopeng.he@intel.com> <1448028587-7718-1-git-send-email-shaopeng.he@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Shaopeng He Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id D6AF73979 for ; Fri, 20 Nov 2015 17:35:14 +0100 (CET) Received: by pacdm15 with SMTP id dm15so121010803pac.3 for ; Fri, 20 Nov 2015 08:35:14 -0800 (PST) In-Reply-To: <1448028587-7718-1-git-send-email-shaopeng.he@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 20 Nov 2015 22:09:47 +0800 Shaopeng He wrote: > vlan_tci should be copied from RX descriptor to mbuf, > and flag PKT_RX_VLAN_PKT should be set for every RX packet, > this patch fixes this issue. > Packets in fm10k device always carry at least one VLAN tag. > For those packets coming in without VLAN tag, > the port default VLAN tag will be used. > So in fm10k, always PKT_RX_VLAN_PKT flag is set and vlan_tci > is valid for each RX packet's mbuf. > > Signed-off-by: Shaopeng He > --- > ChangeLog: > > v3: > * move flag PKT_RX_VLAN_PKT logic together with vlan_tci > * reword comments > > v2: > * change flag PKT_RX_VLAN_PKT to always set > * preserve the priority bits in vlan_tci > > drivers/net/fm10k/fm10k_rxtx.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c > index 1bac28d..e958865 100644 > --- a/drivers/net/fm10k/fm10k_rxtx.c > +++ b/drivers/net/fm10k/fm10k_rxtx.c > @@ -104,9 +104,6 @@ rx_desc_to_ol_flags(struct rte_mbuf *m, const union fm10k_rx_desc *d) > (FM10K_RXD_STATUS_L4CS | FM10K_RXD_STATUS_L4E))) > m->ol_flags |= PKT_RX_L4_CKSUM_BAD; > > - if (d->d.staterr & FM10K_RXD_STATUS_VEXT) > - m->ol_flags |= PKT_RX_VLAN_PKT; > - > if (unlikely(d->d.staterr & FM10K_RXD_STATUS_HBO)) > m->ol_flags |= PKT_RX_HBUF_OVERFLOW; > > @@ -146,6 +143,15 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > #endif > > mbuf->hash.rss = desc.d.rss; > + /** > + * Packets in fm10k device always carry at least one VLAN tag. > + * For those packets coming in without VLAN tag, > + * the port default VLAN tag will be used. > + * So, always PKT_RX_VLAN_PKT flag is set and vlan_tci > + * is valid for each RX packet's mbuf. > + */ > + mbuf->ol_flags |= PKT_RX_VLAN_PKT; > + mbuf->vlan_tci = desc.w.vlan; > > rx_pkts[count] = mbuf; > if (++next_dd == q->nb_desc) { > @@ -292,6 +298,15 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > rx_desc_to_ol_flags(first_seg, &desc); > #endif > first_seg->hash.rss = desc.d.rss; > + /** > + * Packets in fm10k device always carry at least one VLAN tag. > + * For those packets coming in without VLAN tag, > + * the port default VLAN tag will be used. > + * So, always PKT_RX_VLAN_PKT flag is set and vlan_tci > + * is valid for each RX packet's mbuf. > + */ > + mbuf->ol_flags |= PKT_RX_VLAN_PKT; > + first_seg->vlan_tci = desc.w.vlan; > > /* Prefetch data of first segment, if configured to do so. */ > rte_packet_prefetch((char *)first_seg->buf_addr + Looks good thanks. Acked-by: Stephen Hemminger