From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] eal: fix compile error for old glibc
	caused	by pthread_setname_np()#
Date: Tue, 24 Nov 2015 14:26:24 +0000
Message-ID: <20151124142624.GA947@sivlogin002.ir.intel.com>
References: <20151119165935.GA4888@sivlogin002.ir.intel.com>
 <1447955066-17131-1-git-send-email-ferruh.yigit@intel.com>
 <20151120122105.GB2528@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id B08898E9F
 for <dev@dpdk.org>; Tue, 24 Nov 2015 15:26:27 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20151120122105.GB2528@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 20, 2015 at 12:21:05PM +0000, Bruce Richardson wrote:
> On Thu, Nov 19, 2015 at 05:44:26PM +0000, Ferruh Yigit wrote:
> > Fixes: 67b6d3039e9e ("eal: set name to threads")
> > 
> > pthread_setname_np() function added in glibc 2.12, using this function
> > in older glibc versions cause compile error:
> > error: implicit declaration of function "pthread_setname_np"
> > 
> > This patch adds "rte_thread_setname" macro and set it according
> > glibc >= 2.12 check, thread naming disabled for older glibc versions,
> > glibc versions that support "pthread_setname_np" will keep using this
> > function.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >  examples/tep_termination/main.c                    | 2 +-
> >  examples/vhost/main.c                              | 2 +-
> >  examples/vhost_xen/main.c                          | 2 +-
> >  lib/librte_eal/common/eal_thread.h                 | 6 ++++++
> >  lib/librte_eal/linuxapp/eal/eal.c                  | 2 +-
> >  lib/librte_eal/linuxapp/eal/eal_interrupts.c       | 2 +-
> >  lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 2 +-
> >  lib/librte_eal/linuxapp/eal/eal_timer.c            | 2 +-
> >  8 files changed, 13 insertions(+), 7 deletions(-)
> >
> I only see changes to linux files above. Does this not also have an implication
> for bsd too?
> 
BSD is not effected from this defect since it doesn't use glibc, 
equivalent BSD libc function pthread_set_name_np() is 10+ years old...

thanks,
ferruh