From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Date: Tue, 24 Nov 2015 14:44:03 -0800 Message-ID: <20151124144403.79811c0a@xeon-e3> References: <1448219615-63746-1-git-send-email-zhihong.wang@intel.com> <1448219615-63746-3-git-send-email-zhihong.wang@intel.com> <20151122182800.397e0701@xeon-e3> <1640963.TLMeDD9tfp@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id B704F8E7D for ; Tue, 24 Nov 2015 23:43:54 +0100 (CET) Received: by pabfh17 with SMTP id fh17so36652613pab.0 for ; Tue, 24 Nov 2015 14:43:54 -0800 (PST) In-Reply-To: <1640963.TLMeDD9tfp@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 24 Nov 2015 22:13:28 +0100 Thomas Monjalon wrote: > 2015-11-22 18:28, Stephen Hemminger: > > On Sun, 22 Nov 2015 14:13:35 -0500 > > Zhihong Wang wrote: > > > > > The kernel fills new allocated (huge) pages with zeros. > > > DPDK just has to populate page tables to trigger the allocation. > > > > > > Signed-off-by: Zhihong Wang > > > > Nice, especially on slow machines or with large memory. > > > > Acked-by: Stephen Hemminger > > Yes very nice. > I think it's too late to integrate this change which can have some > unpredictable side effects. > Do you agree to wait for 2.3? What side effects? Either it is zero or it is not. Only some broken architecture would have an issue.