From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] net: fix build with gcc 4.4.7 and strict
 aliasing
Date: Tue, 24 Nov 2015 15:49:27 +0000
Message-ID: <20151124154926.GB17696@bricha3-MOBL3>
References: <1448377959-4440-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <7ADD74816B4C8A45B56203CBA65FE5A61D98E602@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 038A737B8
 for <dev@dpdk.org>; Tue, 24 Nov 2015 16:49:30 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <7ADD74816B4C8A45B56203CBA65FE5A61D98E602@IRSMSX107.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Nov 24, 2015 at 03:47:28PM +0000, Mrzyglod, DanielX T wrote:
> This error fix this situation for IPv6 checksum offload error on RHEL65
> Any optimalisation above -O0 provide error in IPv6 checksum
>=20
>=20
> Step 1 : start testpmd
> ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4  -- -i --portmask=3D=
0x3 --disable-hw-vlan --enable-rx-cksum --crc-strip --txqflags=3D0
>=20
> Step 2 : settings and start
>            set verbose 1
>            set fwd csum
>            start
>=20
> Step 3 : calculate correct checksum values of IPv6/TCP and IPv6/UDP by =
scapy
>            Packets info:  IPv6/UDP:Ether(dst=3D"02:00:00:00:00:00", src=
=3D"90:e2:ba:4a:33:5c")/IPv6(src=3D"::2")/UDP()/("X"*46)
>                           IPv6/TCP:  Ether(src=3D"52:00:00:00:00:00", d=
st=3D"90:e2:ba:4a:33:5d")/IPv6(src=3D"::1")/TCP()/("X"*46)
>=20
> Step 4 : Send two packets with wrong checksum value,and calculate the r=
ight checksum value by port,packets received on another port
>            Send packets info: IPv6/UDP=EF=BC=9AEther(dst=3D"90:e2:ba:4a=
:33:5d", src=3D"52:00:00:00:00:00")/IPv6(src=3D"::1")/UDP(chksum=3D0xf)/(=
"X"*46)
>                               IPv6/TCP=EF=BC=9AEther(dst=3D"90:e2:ba:4a=
:33:5d", src=3D"52:00:00:00:00:00")/IPv6(src=3D"::1")/TCP(chksum=3D0xf)/(=
"X"*46)
>=20
> RESULTS:
> 'IPv6/TCP': ['0xd41']}, 'IPv6/UDP': ['0x7d07'],
>=20
> EXPECTED RESULTS:
> 'IPv6/TCP': ['0x9f5e']}, 'IPv6/UDP': ['0xf26']

Hi Daniel,

this sort of detail - perhaps in abbreviated form - should be in the comm=
it
message for the patch. Can you perhaps do a V2 to include it?

/Bruce