From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Aligning net/ethernet.h and rte_ether.h
Date: Wed, 2 Dec 2015 11:45:58 -0800
Message-ID: <20151202114558.7980fad9@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 2D2C48D86
 for <dev@dpdk.org>; Wed,  2 Dec 2015 20:45:49 +0100 (CET)
Received: by pacdm15 with SMTP id dm15so49342884pac.3
 for <dev@dpdk.org>; Wed, 02 Dec 2015 11:45:48 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id 7sm5948577pfb.78.2015.12.02.11.45.47
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 02 Dec 2015 11:45:48 -0800 (PST)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The two header files net/ethenet.h and rte_ether.h are source
incompatiable right now. They both define a bunch of constants
and struct ether_addr; the effective values are the same but
the structure element name is different.

/usr/include/net/ether.h
/* This is a name for the 48 bit ethernet address available on many
   systems.  */
struct ether_addr
{
  u_int8_t ether_addr_octet[ETH_ALEN];
} __attribute__ ((__packed__));

lib/librte_ether/rte_ether.h
struct ether_addr {
	uint8_t addr_bytes[ETHER_ADDR_LEN]; /**< Address bytes in transmission order */
} __attribute__((__packed__));


I would like to just have rte_ether.h include netinet/ether.h
to get rid of the useless duplication, and fix all the code in DPDK.
But this will break out-of-tree source compatibility so best to
wait for DPDK 2.3. Is there a good place to put this in 2.2 release notes?