From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] vhost: don't stall if guest is slow Date: Tue, 8 Dec 2015 11:12:08 +0800 Message-ID: <20151208031208.GJ29571@yliu-dev.sh.intel.com> References: <1449535821-12384-1-git-send-email-stephen@networkplumber.org> <20151208022311.GI29571@yliu-dev.sh.intel.com> <3746283.SiKfvnY0NL@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, nlaw@brocade.com To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ABEE91DB1 for ; Tue, 8 Dec 2015 04:11:12 +0100 (CET) Content-Disposition: inline In-Reply-To: <3746283.SiKfvnY0NL@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Dec 08, 2015 at 03:30:43AM +0100, Thomas Monjalon wrote: > 2015-12-08 10:23, Yuanhan Liu: > > On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote: > > > When guest is booting (or any othertime guest is busy) it is possible > > > for the small receive ring (256) to get full. If this happens the > > > vhost library should just return normally. It's current behavior > > > of logging just creates massive log spew/overflow which could even > > > act as a DoS attack against host. > > > > > > Reported-by: Nathan Law > > > Signed-off-by: Stephen Hemminger > > > > Acked-by: Yuanhan Liu > > Yuanhan, please what is your opinion about the balance benefit/risk > of this patch for 2.2? Thomas, I agree with Stephen that such log is not necessary as it's a fair normal case. However, I see no too much benefit/risk for 2.2: it just removes a debug log after all. --yliu