From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: New Coverity warnings Date: Tue, 8 Dec 2015 08:50:04 -0800 Message-ID: <20151208085004.2d4440f5@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: dev@dpdk.org Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id E400B37A6 for ; Tue, 8 Dec 2015 17:49:55 +0100 (CET) Received: by pacej9 with SMTP id ej9so14631555pac.2 for ; Tue, 08 Dec 2015 08:49:55 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id tb8sm5985627pab.22.2015.12.08.08.49.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2015 08:49:54 -0800 (PST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" *** CID 120410: Error handling issues (CHECKED_RETURN) /examples/l2fwd-keepalive/main.c: 571 in dead_core() 565 566 static void 567 dead_core(__attribute__((unused)) void *ptr_data, const int id_core) 568 { 569 printf("Dead core %i - restarting..\n", id_core); 570 if (rte_eal_get_lcore_state(id_core) == FINISHED) { >>> CID 120410: Error handling issues (CHECKED_RETURN) >>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times). 571 rte_eal_wait_lcore(id_core); 572 rte_eal_remote_launch(l2fwd_launch_one_lcore, NULL, id_core); 573 } else { 574 printf("..false positive!\n"); 575 } 576 } ** CID 37790: Error handling issues (CHECKED_RETURN) /examples/bond/main.c: 593 in cmd_stop_parsed() ________________________________________________________________________________________________________ *** CID 37790: Error handling issues (CHECKED_RETURN) /examples/bond/main.c: 593 in cmd_stop_parsed() 587 "lcore_main not running on core:%d\n", 588 global_flag_stru_p->LcoreMainCore); 589 rte_spinlock_unlock(&global_flag_stru_p->lock); 590 return; 591 } 592 global_flag_stru_p->LcoreMainIsRunning = 0; >>> CID 37790: Error handling issues (CHECKED_RETURN) >>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times). 593 rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore); 594 cmdline_printf(cl, 595 "lcore_main stopped on core:%d\n", 596 global_flag_stru_p->LcoreMainCore); 597 rte_spinlock_unlock(&global_flag_stru_p->lock); 598 } ** CID 37789: Error handling issues (CHECKED_RETURN) /examples/bond/main.c: 631 in cmd_quit_parsed() ________________________________________________________________________________________________________ *** CID 37789: Error handling issues (CHECKED_RETURN) /examples/bond/main.c: 631 in cmd_quit_parsed() 625 global_flag_stru_p->LcoreMainCore); 626 rte_spinlock_unlock(&global_flag_stru_p->lock); 627 cmdline_quit(cl); 628 return; 629 } 630 global_flag_stru_p->LcoreMainIsRunning = 0; >>> CID 37789: Error handling issues (CHECKED_RETURN) >>> Calling "rte_eal_wait_lcore" without checking return value (as is done elsewhere 32 out of 40 times). 631 rte_eal_wait_lcore(global_flag_stru_p->LcoreMainCore); 632 cmdline_printf(cl, 633 "lcore_main stopped on core:%d\n", 634 global_flag_stru_p->LcoreMainCore); 635 rte_spinlock_unlock(&global_flag_stru_p->lock); 636 cmdline_quit(cl);