From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Viktorin Subject: Re: [[RFC PATCH]] lib/ether: fix 16-bit unaligned access Date: Tue, 8 Dec 2015 21:55:04 +0100 Message-ID: <20151208215504.3c2de0c8@jvn> References: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> <12400151.dpjLSRpzoz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 93123559C for ; Tue, 8 Dec 2015 21:55:11 +0100 (CET) In-Reply-To: <12400151.dpjLSRpzoz@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 08 Dec 2015 21:30:03 +0100 Thomas Monjalon wrote: > 2015-12-08 20:29, Jan Viktorin: > > (I considered to not add the cover-letter as this is just a single small patch. > > I hope it does not matter a lot. Is there any convention how to do this?) > > The main interest of splitting patches or adding a cover letter it to have > a place to explain the changes. When you have several changes, they deserve > several patches to provide an accurate explanation. In such case, you may > need a cover letter to describe the global idea of the series. A cover letter > is also helpful for mail threading and acking all the series. > When you have only one change, one email is enough. That's good. Should there be a way how to separate the "inline-cover" and the commit? > > John, should we add this explanation in the contributing guide? -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic