From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] virtio: fix wrong queue index for
 VIRTIO_PCI_QUEUE_SEL
Date: Thu, 10 Dec 2015 09:33:19 +0800
Message-ID: <20151210013319.GO29571@yliu-dev.sh.intel.com>
References: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com>
 <4152327.aAbH2kO9Wx@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 4723B567E
 for <dev@dpdk.org>; Thu, 10 Dec 2015 02:32:14 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <4152327.aAbH2kO9Wx@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Dec 09, 2015 at 09:09:27PM +0100, Thomas Monjalon wrote:
> 2015-12-08 11:05, Yuanhan Liu:
> > We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx,
> > but not vq->queue_id.
> > 
> > vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(),
> > which always starts from 0 no matter which queue it is. However,
> > for virtio, even number is for RX queue, and odd number is for
> > TX queue.
> > 
> > Fixes: 5382b188fb8a ("virtio: add queue release")
> > 
> > Cc: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> Bernard was not CC'ed.

Weird, it was indeed in the CC list (in the patch I sent) on my
email client.

	--yliu