From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] doc: add patch submit cheatsheet Date: Thu, 10 Dec 2015 09:37:57 +0800 Message-ID: <20151210013757.GP29571@yliu-dev.sh.intel.com> References: <1449678215-25698-1-git-send-email-harry.van.haaren@intel.com> <22661588.S5N3t0Qb91@xps13> <20151209165344.GA4724@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: Bruce Richardson Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 59CADDE0 for ; Thu, 10 Dec 2015 02:36:45 +0100 (CET) Content-Disposition: inline In-Reply-To: <20151209165344.GA4724@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 09, 2015 at 04:53:45PM +0000, Bruce Richardson wrote: > On Wed, Dec 09, 2015 at 04:47:42PM +0000, Van Haaren, Harry wrote: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > It would be better with a colon: > > > Fixes: line > > > > Ok, will send a v2 with that fix. > > > > > > git send-email -N --to > > > Why -N? > > > > -N sets the Number of patches to send, when not sending .patch files but sending the latest commits of the current branch in git. > > > > Would you prefer if the sending of .patch files was documented? I'm indifferent - but learned the -N way first :) > > >From my point of view, yes. I think using format-patch followed by a separate > send-email is a better, and safer, workflow, as it allows multiple edits and > checks of the patches before sending. +1 --yliu