From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] doc: announce API change for rte_ether.h
Date: Mon, 14 Dec 2015 09:30:58 -0800
Message-ID: <20151214093058.2207f569@xeon-e3>
References: <1449790022-24126-1-git-send-email-stephen@networkplumber.org>
 <2618453.kF8WIUB5uB@xps13> <20151214153055.GA37304@bricha3-MOBL3>
 <3122170.KpSg9jKaig@xps13> <20151214160025.GA37212@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
 [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 4645091CC
 for <dev@dpdk.org>; Mon, 14 Dec 2015 18:30:51 +0100 (CET)
Received: by padhk6 with SMTP id hk6so66860057pad.2
 for <dev@dpdk.org>; Mon, 14 Dec 2015 09:30:50 -0800 (PST)
In-Reply-To: <20151214160025.GA37212@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> > FreeBSD
> > -------
> > 
> > struct ether_addr {                                                                                              
> >   u_char octet[ETHER_ADDR_LEN];
> > } __packed;
> > 
> > struct ether_header {
> >   u_char  ether_dhost[ETHER_ADDR_LEN];
> >   u_char  ether_shost[ETHER_ADDR_LEN];
> >   u_short ether_type;
> > } __packed;
> > 
> 
> Unfortunate. While the idea seems good, I think the structures being different
> on the different OS's is a problem that need to be solved before we make such
> a change.

The different BSD variants have different definitions (ie NetBSD different than FreeBSD)

Since the data structures are conformant, the other possiblity
is adding ether_ntoa family prototypes to rte_ether.h