From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer Date: Mon, 14 Dec 2015 19:47:32 +0800 Message-ID: <20151214114732.GB29571@yliu-dev.sh.intel.com> References: <1449763652-86292-1-git-send-email-huawei.xie@intel.com> <20151214030158.GA29571@yliu-dev.sh.intel.com> <1485514.3e9eA57k0j@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7E65C37B2 for ; Mon, 14 Dec 2015 12:47:42 +0100 (CET) Content-Disposition: inline In-Reply-To: <1485514.3e9eA57k0j@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 14, 2015 at 10:32:24AM +0100, Thomas Monjalon wrote: > 2015-12-14 11:01, Yuanhan Liu: > > On Fri, Dec 11, 2015 at 12:07:32AM +0800, Huawei@dpdk.org wrote: > > > The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause > > > issue because in the simple TX mode we don't use the header. This patch > > > makes the header desc point to different buffer. > > > > > > Signed-off-by: Huawei Xie > > > > Acked-by: Yuanhan Liu > > Does it fix something in the current behaviour? It's more like a logic fixing to me. > I have the feeling it may wait for 2.3. It's been introduced in v2.2, with Huawei's simple tx patchset. Therefore, I guess 2.2 is good to go? --yliu