From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] mk: fix examples build failure
Date: Mon, 28 Dec 2015 12:53:19 +0800
Message-ID: <20151228045319.GC18863@yliu-dev.sh.intel.com>
References: <CADvXkJ4rowM8vE1BUzOWuSVU_CpZii+q5ydsLihNNo7Pgij4Tg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: steeven lee <steeven@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 4806B379E
 for <dev@dpdk.org>; Mon, 28 Dec 2015 05:51:05 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CADvXkJ4rowM8vE1BUzOWuSVU_CpZii+q5ydsLihNNo7Pgij4Tg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Dec 24, 2015 at 08:38:07PM +0800, steeven lee wrote:
> 1. Fix examples build failure

Paste the build error here, so that we know you are acutally fixing a
build error. And if it's a build error specific to some GCC, or Linux
distribution, please also note it in the commit log.

> 2. make build as default output folder name

No, please do not do two things in one patch.

	--yliu
> 
> Signed-off-by: steeven <steeven@gmail.com>
> ---
>  mk/internal/rte.extvars.mk | 4 ++--
>  mk/rte.extsubdir.mk        | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
> index 040d39f..cabef0a 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
>  export RTE_EXTMK
> 
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build
>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
>  endif
> 
>  #
> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
> index f50f006..819020a 100644
> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
>         @echo "== $@"
>         $(Q)$(MAKE) -C $(@) \
>                 M=$(CURDIR)/$(@)/Makefile \
> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>                 S=$(CURDIR)/$(@) \
> -- 
> 1.9.1