From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device Date: Mon, 4 Jan 2016 09:24:10 -0800 Message-ID: <20160104092410.11311412@xeon-e3> References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <1451843773-103006-5-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Huawei Xie Return-path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id A9A298E9D for ; Mon, 4 Jan 2016 18:24:03 +0100 (CET) Received: by mail-pa0-f54.google.com with SMTP id yy13so107676445pab.3 for ; Mon, 04 Jan 2016 09:24:03 -0800 (PST) In-Reply-To: <1451843773-103006-5-git-send-email-huawei.xie@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 4 Jan 2016 01:56:13 +0800 Huawei Xie wrote: > + if (pci_dev->kdrv != RTE_KDRV_NONE) { > + PMD_INIT_LOG(INFO, > + "kernel driver is manipulating this device." \ > + " Please unbind the kernel driver."); Splitting strings in general is a bad idea since it makes it harder to find log messages. Also the first clause is lower case and the second is captialized. Lastly, the backslash continuation is unnecessary here and will cause checkpatch warning.