From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 4/4] virtio: check if any kernel driver is
 manipulating the device
Date: Mon, 4 Jan 2016 09:29:49 -0800
Message-ID: <20160104092949.7ea534f9@xeon-e3>
References: <20151222035041.GA7532@pxdev.xzpeter.org>
 <1450982292-129560-1-git-send-email-huawei.xie@intel.com>
 <1450982292-129560-5-git-send-email-huawei.xie@intel.com>
 <C37D651A908B024F974696C65296B57B4C5730C4@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Xie, Huawei" <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id D51028E9D
 for <dev@dpdk.org>; Mon,  4 Jan 2016 18:29:41 +0100 (CET)
Received: by mail-pf0-f172.google.com with SMTP id e65so152264632pfe.1
 for <dev@dpdk.org>; Mon, 04 Jan 2016 09:29:41 -0800 (PST)
In-Reply-To: <C37D651A908B024F974696C65296B57B4C5730C4@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 4 Jan 2016 09:02:53 +0000
"Xie, Huawei" <huawei.xie@intel.com> wrote:

> > +		PMD_INIT_LOG(ERR,  
> Better change ERR to INFO and revise the message followed, since user
> might not want to use this device for DPDK.
> > +			"%s(): kernel driver is manipulating this device." \
> > +			" Please unbind the kernel driver.", __func__);

The addition of __func__ here is redundant since this is already in PMD_INIT_LOG macro.