From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH 08/12] pmd/mlx4: add dev_ptype_info_get
 implementation
Date: Mon, 4 Jan 2016 12:11:14 +0100
Message-ID: <20160104111114.GS3806@6wind.com>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1451544799-70776-9-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 583C98E8D
 for <dev@dpdk.org>; Mon,  4 Jan 2016 12:11:33 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id f206so208032227wmf.0
 for <dev@dpdk.org>; Mon, 04 Jan 2016 03:11:33 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1451544799-70776-9-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jianfeng,

I'm only commenting the mlx4/mlx5 bits in this message, see below.

On Thu, Dec 31, 2015 at 02:53:15PM +0800, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  drivers/net/mlx4/mlx4.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 207bfe2..85afa32 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -2836,6 +2836,8 @@ rxq_cleanup(struct rxq *rxq)
>   * @param flags
>   *   RX completion flags returned by poll_length_flags().
>   *
> + * @note: fix mlx4_dev_ptype_info_get() if any change here.
> + *
>   * @return
>   *   Packet type for struct rte_mbuf.
>   */
> @@ -4268,6 +4270,30 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
>  	priv_unlock(priv);
>  }
>  
> +static int
> +mlx4_dev_ptype_info_get(struct rte_eth_dev *dev, uint32_t ptype_mask,
> +		uint32_t ptypes[])
> +{
> +	int num = 0;
> +
> +	if ((dev->rx_pkt_burst == mlx4_rx_burst)
> +			|| (dev->rx_pkt_burst == mlx4_rx_burst_sp)) {
> +		/* refers to rxq_cq_to_pkt_type() */
> +		if ((ptype_mask & RTE_PTYPE_L3_MASK) == RTE_PTYPE_L3_MASK) {
> +			ptypes[num++] = RTE_PTYPE_L3_IPV4;
> +			ptypes[num++] = RTE_PTYPE_L3_IPV6;
> +		}
> +
> +		if ((ptype_mask & RTE_PTYPE_INNER_L3_MASK) == RTE_PTYPE_INNER_L3_MASK) {
> +			ptypes[num++] = RTE_PTYPE_INNER_L3_IPV4;
> +			ptypes[num++] = RTE_PTYPE_INNER_L3_IPV6;
> +		}
> +	} else
> +		num = -ENOTSUP;
> +
> +	return num;
> +}

I think checking for mlx4_rx_burst and mlx4_rx_burst_sp is unnecessary at
the moment, all RX burst functions do update the packet_type field, no need
for extra complexity.

Same comment for mlx5. 

> +
>  /**
>   * DPDK callback to get device statistics.
>   *
> @@ -4989,6 +5015,7 @@ static const struct eth_dev_ops mlx4_dev_ops = {
>  	.stats_reset = mlx4_stats_reset,
>  	.queue_stats_mapping_set = NULL,
>  	.dev_infos_get = mlx4_dev_infos_get,
> +	.dev_ptypes_info_get = mlx4_dev_ptype_info_get,
>  	.vlan_filter_set = mlx4_vlan_filter_set,
>  	.vlan_tpid_set = NULL,
>  	.vlan_strip_queue_set = NULL,
> -- 
> 2.1.4
> 

-- 
Adrien Mazarguil
6WIND