From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 3/4] vmxnet3: add TSO support
Date: Mon, 4 Jan 2016 21:14:31 -0800
Message-ID: <20160104211431.7331034d@xeon-e3>
References: <1451960899-26881-1-git-send-email-yongwang@vmware.com>
 <1451960899-26881-4-git-send-email-yongwang@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 55A4D91F0
 for <dev@dpdk.org>; Tue,  5 Jan 2016 06:14:26 +0100 (CET)
Received: by mail-pf0-f178.google.com with SMTP id q63so177962222pfb.0
 for <dev@dpdk.org>; Mon, 04 Jan 2016 21:14:26 -0800 (PST)
In-Reply-To: <1451960899-26881-4-git-send-email-yongwang@vmware.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon,  4 Jan 2016 18:28:18 -0800
Yong Wang <yongwang@vmware.com> wrote:

> +	mbuf = txq->cmd_ring.buf_info[eop_idx].m;
> +	if (unlikely(mbuf == NULL))
> +		rte_panic("EOP desc does not point to a valid mbuf");
> +	else

The unlikely is really not needed with rte_panic since it is declared
with cold attribute which has same effect.

Else is unnecessary because rte_panic never returns.