From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] fix checkpatch errors
Date: Tue, 5 Jan 2016 10:27:52 +0800
Message-ID: <20160105022752.GG26062@yliu-dev.sh.intel.com>
References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E36031CD068@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 49CD991E9
 for <dev@dpdk.org>; Tue,  5 Jan 2016 03:24:17 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36031CD068@SHSMSX103.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 05, 2016 at 02:21:12AM +0000, Tan, Jianfeng wrote:
> 
> 
> > -----Original Message-----
> > From: Xie, Huawei
> > Sent: Monday, January 4, 2016 9:52 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
> > Subject: [PATCH] fix checkpatch errors
> > 
> > Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> ...
> >  	mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));
> > -	return (rte_mempool_lookup((const char *)pool_name));
> > +	return rte_mempool_lookup((const char *)pool_name);
> 
> Hi Huawei,
> 
> Assume this patch is to solve below error (reported by checkpatch):
> ERROR: return is not a function, parentheses are not required
> 
> So maybe above fix is not necessary? Involve more people to discuss.

This fix is good to me.

> And please include the error message in the commit message.

+1

	--yliu