From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 03/12] linuxapp: eal: arm: Always return 0
 for rte_eal_iopl_init()
Date: Thu, 7 Jan 2016 10:14:07 -0800
Message-ID: <20160107101407.54b18175@xeon-e3>
References: <1452184390-5994-1-git-send-email-sshukla@mvista.com>
 <1452184390-5994-4-git-send-email-sshukla@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Santosh Shukla <sshukla@mvista.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 72536B3D6
 for <dev@dpdk.org>; Thu,  7 Jan 2016 19:14:00 +0100 (CET)
Received: by mail-pa0-f51.google.com with SMTP id ho8so3612248pac.2
 for <dev@dpdk.org>; Thu, 07 Jan 2016 10:14:00 -0800 (PST)
In-Reply-To: <1452184390-5994-4-git-send-email-sshukla@mvista.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  7 Jan 2016 22:03:00 +0530
Santosh Shukla <sshukla@mvista.com> wrote:

>  #else
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> +	return 0; /* iopl syscall not supported for ARM/ARM64 */
> +#endif
>  	return -1;
>  #endif

Minor net why not:

#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
	return -1
#else

That way you won't generate two return statements and potentially
trigger warnings from static checkers.