From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 0/6] vmxnet3 TSO,
	tx cksum offload and cleanups
Date: Tue, 12 Jan 2016 20:56:34 -0800
Message-ID: <20160112205634.7bd2d50d@xeon-e3>
References: <1452650917-7960-1-git-send-email-yongwang@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 8A6A15686
 for <dev@dpdk.org>; Wed, 13 Jan 2016 05:56:32 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id yy13so259010200pab.3
 for <dev@dpdk.org>; Tue, 12 Jan 2016 20:56:32 -0800 (PST)
In-Reply-To: <1452650917-7960-1-git-send-email-yongwang@vmware.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 12 Jan 2016 18:08:31 -0800
Yong Wang <yongwang@vmware.com> wrote:

> v4:
> * moved cleanups to separate patches
> * correctly handled multi-seg pkts with data ring used
> 
> v3:
> * fixed comments from Stephen
> * added performance number for tx data ring
> 
> v2:
> * fixed some logging issues when debug option turned on
> * updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
> 
> This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
> One of the use cases is to support STT.  It also restores the tx
> data ring feature that was removed from a previous patch.
> 
> Yong Wang (6):
>   vmxnet3: fix typos and remove unused struct
>   vmxnet3: restore tx data ring support
>   vmxnet3: cleanup txNumDeferred usage
>   vmxnet3: add tx l4 cksum offload
>   vmxnet3: add TSO support
>   vmxnet3: announce device offload capability
> 
>  doc/guides/rel_notes/release_2_3.rst    |  11 +++
>  drivers/net/vmxnet3/base/includeCheck.h |  39 --------
>  drivers/net/vmxnet3/base/vmxnet3_defs.h |   9 +-
>  drivers/net/vmxnet3/vmxnet3_ethdev.c    |  16 +++-
>  drivers/net/vmxnet3/vmxnet3_ring.h      |  13 ---
>  drivers/net/vmxnet3/vmxnet3_rxtx.c      | 160 +++++++++++++++++++++++++-------
>  6 files changed, 151 insertions(+), 97 deletions(-)
>  delete mode 100644 drivers/net/vmxnet3/base/includeCheck.h
> 

Looks good. The only thing maybe worth adding would be some more checks
int the vmxnet3_dev_configure for unsupported offload bits, etc.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>